docs: add Walrus Console beta documentation#3540
Conversation
|
📋 afdocs check resultsURL: https://MystenLabs.github.io/walrus/pr-preview/pr-3540/ |
Style Guide AuditAll 5 file(s) pass the style guide audit. |
jessiemongeon1
left a comment
There was a problem hiding this comment.
Overall a good start, but several areas need some revisions.
- In some places, you list "available in beta on Mainnet" and then "available in alpha on Testnet", this needs to be consistent so that it is clear what feature set is currently available when these docs are published.
- There are several things not defined or explained, such as Pearl wallet
- All code snippets need to be sourced from their original source repo (using the ImportContent component), not copy/pasted into the docs
- Inconsistencies with naming schemes/variables
- Always prefer info over note for admonitions
- Other misc style guide/structure/wording adjustments needed
jessiemongeon1
left a comment
There was a problem hiding this comment.
Overall a good start, but several areas need some revisions.
- In some places, you list "available in beta on Mainnet" and then "available in alpha on Testnet", this needs to be consistent so that it is clear what feature set is currently available when these docs are published.
- There are several things not defined or explained, such as Pearl wallet
- All code snippets need to be sourced from their original source repo (using the ImportContent component), not copy/pasted into the docs
- Inconsistencies with naming schemes/variables
- Always prefer info over note for admonitions
- Other misc style guide/structure/wording adjustments needed
Apply review feedback on the Walrus Console beta docs: - Standardize launch framing: product pages describe a closed, invite-only Mainnet beta; the API reference and quickstart keep the API as alpha / Testnet-only, resolving the alpha-vs-beta inconsistency across pages. - Title-case all page titles; use "Quick Start" consistently. - Switch all :::note admonitions to :::info. - Add Seal (/docs/data-security), Sui zkLogin, Sui address, Enoki, MCP, and Discord links; replace placeholder "/" links. - Capitalize "ID" in prose and clarify the API parameter tables' "In" column as "Location". - Move the encryption/privacy warning higher on the overview page and trim the duplicated API-key role details. - Condense the not-yet-available Apple sign-in section. - Apply reviewer inline suggestions (error shape, async wording, KiB, retry guidance, character-length clarifications) and remove redundant manual "Next steps" sections in favor of Docusaurus pagination. - Add a canonical-source pointer for the quickstart snippets. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQ8Q5FL8je9mpXv93ff23R
|
Thanks for the thorough review, @jessiemongeon1. Pushed a commit addressing the feedback ( Launch framing (the alpha-vs-beta inconsistency). Standardized on: the product is a closed, invite-only Mainnet beta (overview, sign-in, storage, and the quickstart intro), while the external API is called out as alpha and Testnet-only (per your suggestion on the API reference note). The quickstart note now states both explicitly so the Testnet-preview-vs-Mainnet-beta relationship is clear rather than mixed per page. Applied directly: all inline suggestion blocks; Title Case on every page title; "Quick Start" used consistently; every Two items that need your call — not fully mechanical:
For the links where no canonical public URL exists yet (Pearl wallet, Personal Space), I used inline definitions / internal anchors instead of external links. Generated by Claude Code |
|
The ImportContent module works for all sources, not just local content, so that analysis from Claude is incorrect. See here from the existing Walrus docs: https://raw.githubusercontent.com/MystenLabs/walrus/refs/heads/main/docs/content/examples/walrus-relay.mdx The format is: and yes, the prerequisite component is the Tabs/TabItem label="Prerequisites" pattern |
- "may" -> "might" (api-reference, overview, quickstart) - "on-chain" -> "onchain" (api-reference) - present tense over future/passive: "will accept" -> "accepts" (auth), "will be part of the general availability release" -> "arrive at general availability" (overview), "will ship" -> "ships" (storage-epochs) Left the two "capitalize testnet" flags unchanged: both point at the testnet.harbor.walrus.xyz hostname in link text, not prose. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQ8Q5FL8je9mpXv93ff23R
|
Applied the style-guide audit fixes in
I left the two "capitalize testnet" flags (auth L21, quickstart L34) unchanged on purpose: both point at Generated by Claude Code |
Wrap the quickstart prerequisites in the shared <Tabs><TabItem label="Prerequisites"> pattern used elsewhere in the docs, per review feedback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQ8Q5FL8je9mpXv93ff23R
- Reword the two `testnet.harbor.walrus.xyz` link texts to "the Walrus Console app" so no lowercase hostname token appears in prose (URL unchanged). - Active voice in storage-epochs: "is not renewed" -> "you do not renew it"; "its storage is allowed to lapse" -> "its storage lapses". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQ8Q5FL8je9mpXv93ff23R
Replace the inline TypeScript snippets (signing, Seal encrypt/decrypt) and the hardcoded package/key-server IDs with <ImportContent> pulls from the public MystenLabs/walrus-harbor-quickstart example: - config.ts and lib/seal.ts introduced once as the canonical constants and helpers. - sign-reserve.ts, encrypt-file.ts, and decrypt-file.ts imported at Steps 4, 6, and 9, with pnpm run commands. This removes the copy/paste snippets flagged in review and keeps the package IDs and Seal key-server IDs in sync with the source repo. Also repoint the source note from the private harbor repo to the public quickstart repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQ8Q5FL8je9mpXv93ff23R
|
Wired the quickstart code to source from the repo via
One thing I left as-is: the Get help section still links Generated by Claude Code |
There was a problem hiding this comment.
Looking better, but still a few things needed:
- In "Get Help", I’d point to Discord, the public quickstart repo, or another public support path.
- Apple availability is still inconsistent:
auth.mdx:11/25says Apple is “soon”, whileoverview.mdx:85lists “Google and Apple sign-in” as Beta. - Quick Start has a confusing double API-key flow:
quickstart.mdx:40-48creates an API key, then 65-72 creates an “encrypted-capable” API key and service key. I’d collapse that into one explicit “create aread_writeencrypted-capable key and save bothhbr_…+suiprivkey1…” path. api-reference.mdx:247-249says poll status until completed, then says status may become 404 once the job leaves the queue. That matches the hosted OpenAPI wording, but I’d make the user guidance clearer: “if it 404s after upload, check file metadata before treating it as failed.”- The Mainnet closed beta vs Testnet alpha API framing is awkward/a bit confusing.
- Get Help: drop the private harbor/issues link; point to the Walrus Discord and the public walrus-harbor-quickstart issues. - Apple availability: overview no longer lists Apple sign-in as Beta; the capability table shows Google (Beta) and Apple (Soon), matching auth.mdx. - Quickstart: collapse the two API-key steps into one explicit "create a read_write encryption-capable key, save both hbr_ and suiprivkey1" path; renumber the remaining steps (now 1-8). - API reference: clarify the upload-status 404 guidance — a 404 after upload means check file metadata before treating it as a failure. - Framing: on the quickstart, lead with the Testnet-alpha API framing instead of juxtaposing it with the Mainnet closed-beta product framing (which stays on the overview and sign-in pages). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQ8Q5FL8je9mpXv93ff23R
|
Thanks — addressed all of these in
The private Generated by Claude Code |
Docs: add Walrus Console beta documentation
Description
Summary
Adds the initial Walrus Console documentation set for the beta launch. Five pages under
docs/content/console/:Sources: the hosted quickstart and OpenAPI spec at
api.testnet.harbor.walrus.xyz, and theConsole PRD and roadmap. Content is written to the beta surface (private Seal-encrypted buckets,
files, Google and Apple zkLogin), with GA and post-GA capabilities marked as such.
Notes for reviewers
Harbor name, so prose uses "Walrus Console" while literal identifiers (
hbr_keys,HARBOR_*package constants) are kept as-is.
via
<ImportContent>from the publicMystenLabs/walrus-harbor-quickstartexample, so it staysin sync with the source rather than being copy/pasted here.
Follow-ups before merge
than guessed.
Before merge (run locally)
editorconfig-checkerandtypospass..mdxfiles are exempt from the 150-characterwrap; if any
.mdfile is added, hard-wrap prose to about 100 columns.docs:prefix for the semantic PR check.Tickets
Closes BEDU-667, closes BEDU-659, closes BEDU-657, closes BEDU-658, closes BEDU-664.